This repository was archived by the owner on Aug 13, 2024. It is now read-only.
chore: remove duplicated click #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiyaig
force-pushed
the
chore/click
branch
3 times, most recently
from
24ca40e to
2df79f5
Compare
Valentina1133
approved these changes
Mar 14, 2024
anastasiyaig
force-pushed
the
chore/click
branch
from
2df79f5 to
f245e25
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #585
CI run_1 full scope: https://ci.status.im/job/status-desktop/job/e2e/job/manual/1660/allure/
CI run_2 full scope: https://ci.status.im/job/status-desktop/job/e2e/job/manual/1662/console
Removed duplicated native click
Aligned click with left and right buttons to both using Qt buttons
Renamed a method of right clicking to be named like that
Removed unnecessary (?) extra click method in Button class
this is done to avoid clicking in the middle of the object, also these params must be int otherwise they are not accepted by mouseClick and then it is defaulted to click to the center of the object. We dont want to have that just because for some elements (like checkboxes) clicking in the center may lead to click any other element like link (see screenshot)